FQN being used for classes in same package #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2023 05:29
|
Thank you. It seems that this fixes issue 2017. |
|
The call to parent getDependencies is important as it should detect namespace imports on variables. But unfortunately, it also adds the variable itself to the import, which is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting one of the changes from commit f81d1ac58de0e89d1c596b84a6eec6b00ffb16a6, because it caused the use of the FQN for classes defined within the same package
additionally added a comment on class variable names being added as dependencies, that maybe can/should be removed, but is not causing issues (I think)