Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide audio quality option 添加下载音质的 CLI 选项 #19

Merged
merged 8 commits into from
May 27, 2024

Conversation

un4gt
Copy link
Contributor

@un4gt un4gt commented May 18, 2024

description

According to 添加下载音质的 CLI 选项 :

just provide three audio quality options: 64, 132 and 192 .

Usage

The default value of audio quality is 64 .
image

set audio quality to 132

bilifm uid xxxx -q 132

192 same as above

bilifm uid xxxx -q 192

@jingfelix jingfelix added codekitchen enhancement New feature or request labels May 18, 2024
@jingfelix jingfelix self-requested a review May 19, 2024 10:40
@robo-dani
Copy link
Contributor

能把默认的品质改为最高的(192)吗, 比较一开始默认第一个的都是最高音质的.

感觉 audio_quality_map 可以转化为 EnumQuality 的函数之类的, 这样就能少一个import

@un4gt
Copy link
Contributor Author

un4gt commented May 22, 2024

我修改重新pull request 以下。

src/bilifm/command.py Outdated Show resolved Hide resolved
Signed-off-by: jingfelix <jingfelix@outlook.com>
@jingfelix
Copy link
Owner

Changelog:

  • series 选项也添加了 audio_quality 选项
  • 解决与主分支的冲突

@jingfelix jingfelix merged commit 6e30546 into jingfelix:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codekitchen enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants