Revert "core/vote: not vote if too late for next in turn validator (b…

…nb-chain#2568)" This reverts commit c96fab0.
jingjunLi · Jul 22, 2024 · fc31c54 · fc31c54
1 parent b071097
commit fc31c54
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 15 deletions.
diff --git a/consensus/parlia/parlia.go b/consensus/parlia/parlia.go
@@ -307,10 +307,6 @@ func New(
  return c
 }
 
-func (p *Parlia) Period() uint64 {
- return p.config.Period
-}
-
 func (p *Parlia) IsSystemTransaction(tx *types.Transaction, header *types.Header) (bool, error) {
  // deploy a contract
  if tx.To() == nil {

diff --git a/core/vote/vote_manager.go b/core/vote/vote_manager.go
@@ -4,11 +4,9 @@ import (
  "bytes"
  "fmt"
  "sync"
- "time"
 
  "github.com/ethereum/go-ethereum/common"
  "github.com/ethereum/go-ethereum/consensus"
- "github.com/ethereum/go-ethereum/consensus/parlia"
  "github.com/ethereum/go-ethereum/core"
  "github.com/ethereum/go-ethereum/core/types"
  "github.com/ethereum/go-ethereum/eth/downloader"
@@ -141,15 +139,6 @@ func (voteManager *VoteManager) loop() {
  }
 
  curHead := cHead.Block.Header()
- if p, ok := voteManager.engine.(*parlia.Parlia); ok {
- nextBlockMinedTime := time.Unix(int64((curHead.Time + p.Period())), 0)
- timeForBroadcast := 50 * time.Millisecond // enough to broadcast a vote
- if time.Now().Add(timeForBroadcast).After(nextBlockMinedTime) {
- log.Warn("too late to vote", "Head.Time(Second)", curHead.Time, "Now(Millisecond)", time.Now().UnixMilli())
- continue
- }
- }
-
  // Check if cur validator is within the validatorSet at curHead
  if !voteManager.engine.IsActiveValidatorAt(voteManager.chain, curHead,
  func(bLSPublicKey *types.BLSPublicKey) bool {