-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go 1.20 & generic test #28
base: master
Are you sure you want to change the base?
Go 1.20 & generic test #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Looks like the rowserrcheck is running well with generics cc @jingyugao @ldez
@calebeof, I think it's running well because of fresh Go and |
@Antonboom I think you misinterpreted the LGTM from @calebeof. Also, your change is just an update of libraries that are already updated in golangci-lint. |
I will run my test suite with the current version of rowserrcheck inside golangci-lint and we will see. |
Saw :(
Yep, but I want to keep consistency between Anyway, so maybe you enable 🙏 |
Not a lot, but I think we can create a version just to close the topic of generics. I have to check some elements before creating a release. |
Closes #24