Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch filter (solves #136) #150

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Batch filter (solves #136) #150

merged 1 commit into from
Oct 5, 2019

Conversation

mateka
Copy link
Contributor

@mateka mateka commented Oct 4, 2019

Batch filter implementation: #136 .

@flexferrum
Copy link
Collaborator

flexferrum commented Oct 4, 2019

Submodule 'thirdparty/nonstd/optional-lite' (https://github.com/martinmoene/optional-lite.git) registered for path 'thirdparty/nonstd/optional-lite'
Submodule 'thirdparty/nonstd/string-view-lite' (https://github.com/martinmoene/string-view-lite.git) registered for path 'thirdparty/nonstd/string-view-lite'
Submodule 'thirdparty/nonstd/variant-lite' (https://github.com/martinmoene/variant-lite.git) registered for path 'thirdparty/nonstd/variant-lite'
fatal: No url found for submodule path 'thirdparty/robin-hood-hashing' in .gitmodules

I suppose, the problem is that your branch wasn't properly rebased to the current master:

image

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #150 into master will increase coverage by 0.3%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #150     +/-   ##
=========================================
+ Coverage   88.14%   88.45%   +0.3%     
=========================================
  Files          65       65             
  Lines        8269     8515    +246     
=========================================
+ Hits         7289     7532    +243     
- Misses        980      983      +3
Impacted Files Coverage Δ
src/filters.h 84.21% <ø> (+5.26%) ⬆️
test/filters_test.cpp 100% <100%> (ø) ⬆️
src/filters.cpp 87.95% <93.93%> (+0.59%) ⬆️
test/statements_tets.cpp 100% <0%> (ø) ⬆️
test/errors_test.cpp 99.21% <0%> (ø) ⬆️
src/template_parser.h 92.68% <0%> (+0.96%) ⬆️
src/lexer.h 95.57% <0%> (+1.05%) ⬆️
include/jinja2cpp/error_info.h 100% <0%> (+3.7%) ⬆️
src/error_info.cpp 63.01% <0%> (+4.68%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d544c...a512370. Read the comment docs.

@flexferrum flexferrum merged commit b320a27 into jinja2cpp:master Oct 5, 2019
@mateka mateka deleted the batch-filter branch October 5, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants