Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for length param when sending to avoid allocating byte array. #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnou
Copy link

@johnou johnou commented Nov 10, 2019

We can exploit the fact the WebGL implementation takes a byte array and length ( instance.ws.send(HEAPU8.buffer.slice(bufferPtr, bufferPtr + length)); ) and allow the application to write to a buffer then pass that into the websocket send function instead of always allocating a new byte array eg.

int outputBytes;
while ((outputBytes = _tls.ReadOutput(_outgoingBuffer, 0, _outgoingBuffer.Length)) > 0)
{
  _socket.Send(_outgoingBuffer, outputBytes);
}

@johnou
Copy link
Author

johnou commented Nov 10, 2019

ptal @jirihybek cc @endel

@johnou
Copy link
Author

johnou commented Dec 19, 2019

@jirihybek poke, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant