Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The nim directory can only be placed under the current directory. #499

Closed
jiro4989 opened this issue Jul 8, 2024 · 4 comments · Fixed by #500
Closed

[Bug]: The nim directory can only be placed under the current directory. #499

jiro4989 opened this issue Jul 8, 2024 · 4 comments · Fixed by #500
Assignees
Labels
bug Something isn't working

Comments

@jiro4989
Copy link
Owner

jiro4989 commented Jul 8, 2024

What happened?

nim-install-direcotry doesn't work non-current direcotry.

nim-install-directory: ${{ runner.temp }}

The reason is that using $PWD.

    - name: Set PATH for Unix
      shell: bash
      run: |
        echo "$PWD/${{ inputs.nim-install-directory }}/bin" >> "$GITHUB_PATH"
        echo "$HOME/.nimble/bin" >> "$GITHUB_PATH"

Relevant log output

No response

Actions log url

No response

#483

@jiro4989 jiro4989 added the bug Something isn't working label Jul 8, 2024
@jiro4989 jiro4989 self-assigned this Jul 8, 2024
jiro4989 added a commit that referenced this issue Jul 8, 2024
…499 (#500)

* fix: modifiable parent directory

* ci: add parent directory test
@dlesnoff
Copy link

dlesnoff commented Jul 8, 2024

@jiro4989
Still not fixed apparently!
When re-running job, nim full path is empty! https://github.com/TheAlgorithms/Nim/actions/runs/9840934507/job/27176546752#step:3:38
I tried both with and without a nim_runtime subdirectory.

EDIT: I have different paths in Run actions/checkout@v4:
/home/runner/work/Nim/Nim is the global config directory
and in setup-nim-action@v2:
echo "$parent//home/runner/work/_temp/bin" >> "$GITHUB_PATH"
Strangely, I have this output:
installed nim fullpath:

I guess the temporary variable is not the same between the two different Github actions.

@dlesnoff
Copy link

dlesnoff commented Jul 8, 2024

I tried setting the path litteraly with /home/runner without success.
You can see all my attempts at: TheAlgorithms/Nim#78

@dlesnoff
Copy link

dlesnoff commented Jul 8, 2024

Sorry for the fuss, I was confused.
I wrote nim-install-directory instead of parent-nim-install-directory.
It works well now, thanks for the changes.

@jiro4989
Copy link
Owner Author

jiro4989 commented Jul 9, 2024

I'm glad it solved it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants