Let user show/hide markers on new, ignored and untracked files #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also disable to popup in such files |
r-stein
approved these changes
Nov 22, 2016
|
I rebased and squashed the branch to the latest master. |
This was referenced Nov 28, 2016
…s_on_untracked_file is true. By now GitGutter shows '+' markers on each line for any file within a git repository even with `show_markers_on_untracked_file: false`. But the documentation of this setting quite clearly says: "GitGutter shows icons for new files and ignored files." This commit is to satisfy this description. Result: `show_markers_on_untracked_file: false` -> do not show any marker on ignored, untracked or new files. `show_markers_on_untracked_file: true` (Default) -> show '*' for untracked files -> show 'x' for ignored files -> show '+' for new files# Please enter the commit message for your changes. Lines starting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
show_markers_on_untracked_filesetting quite clearly says: "GitGutter shows icons for new files and ignored files."GitGutter 1.3.0 did behave exactly like documented.
GitGutter 1.4.0 shows '+' markers on each line for any file within a git repository even with
show_markers_on_untracked_file: false.This pull request intends to revert the behaviour to as it was on 1.3.0 to satisfy documentation.
show_markers_on_untracked_file: false-> do not show any marker on ignored, untracked or new files.
show_markers_on_untracked_file: true(Default)-> show '*' for untracked files
-> show 'x' for ignored files
-> show '+' for new files