Update preset-announcement.js to skip restore of idle players #891
Conversation
When using presets all players get backup/restore. This affects a playing player by restoring it to the time of backup state.elapsedTime, even if this player is not included in the preset file and is supposed to be skipped. Even if pauseOthers is set to false, by this behavior the player still get interrupted one sec because it is shifted back to recorded elapsedTime. This PR is changing "saveAll" to "savePresetPlayers" and will backup/restore only players specified in preset file. Idle players are no more affected by running presets. Tested and found more stable when joining/leaving groups after tts or chime clips.
| delete backupPresets[key]; | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
instead of mutating the array to remove "empty", you can add a .filter(Boolean) after the map() when creating backupPresets.
There was a problem hiding this comment.
sorry, I don't know how
lib/helpers/preset-announcement.js
Outdated
| preset.elapsedTime = state.elapsedTime; | ||
| } | ||
| for (var index = 0; index < pset.players.length; ++index) { | ||
| if (pset.players[index].roomName == coordinator.roomName) { |
There was a problem hiding this comment.
I'm not really following the logic here, why would you create a preset for each player in a zone?
There was a problem hiding this comment.
The point is to completely ignore other players from my house. When my daughter was listening spotify in her room, if I had a preset announcement in any other room(s) , at the moment of tts ending, her player track got rewind at the moment of preset backup. Her player was not supposed to be restored at all.
I couldn't find a way to restore only specific player from an allSave preset, so I decided to create separate presets then restore all available.
When using presets all players get backup/restore. This affects a playing player by restoring it to the time of backup state.elapsedTime, even if this player is not included in the preset file and is supposed to be skipped. Even if pauseOthers is set to false, by this behavior the player still get interrupted one sec because it is shifted back to recorded elapsedTime.
This PR is changing "saveAll" to "savePresetPlayers" and will backup/restore only players specified in preset file. Idle players are no more affected by running presets.
Tested and found more stable when joining/leaving groups after tts or chime clips.