Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to run container as non root user? #1447

Open
ghost opened this issue Nov 24, 2022 · 6 comments
Open

Is there any plan to run container as non root user? #1447

ghost opened this issue Nov 24, 2022 · 6 comments

Comments

@ghost
Copy link

ghost commented Nov 24, 2022

No description provided.

@saghul
Copy link
Member

saghul commented Nov 24, 2022

Yes, but it hasn't been a priority.

If you are willing to help, he first step would be to upgrade the s6 overlay to v3, which does allow running as non-root.

Once that is done, switching to non-root would be a next step.

@bsobbe
Copy link

bsobbe commented Mar 24, 2023

@saghul is it gonna be a priority this year?

@saghul
Copy link
Member

saghul commented Apr 3, 2023

I don't have any indication to believe it will be. As I mentioned earlier (#1447 (comment)) migrating to S6 v3 is a pre-requisite to that.

@bsobbe
Copy link

bsobbe commented Jul 19, 2023

@saghul I have successfully migrated docker-jitsi-meet's base image to the latest version of s6-overlay (v3.1.5.0). After a few days of refactoring some of the cont-init and services.d and of course, some changes in Dockerfiles, seems like all the services are now running error-free with the new base.
I am going to do a few more tests during the week just to be sure before moving to add support for non-root users.
I will make sure to create a PR after it's ready, but meanwhile don't hesitate to let me know if there are any specific tests I need to perform.

@saghul
Copy link
Member

saghul commented Jul 19, 2023

This is awesome, thank you!

@bsobbe
Copy link

bsobbe commented Aug 1, 2023

@saghul I made the PR just now: #1584
Looking forward to getting some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants