Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "transport" parameter to createComponent. #242

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Nov 17, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #242 (f167f2b) into master (15981cf) will increase coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #242      +/-   ##
============================================
+ Coverage     38.78%   38.87%   +0.09%     
- Complexity     1359     1360       +1     
============================================
  Files           178      178              
  Lines         12145    12142       -3     
  Branches       1836     1836              
============================================
+ Hits           4710     4720      +10     
+ Misses         6786     6771      -15     
- Partials        649      651       +2     
Impacted Files Coverage Δ
src/main/java/org/ice4j/ice/Agent.java 55.60% <50.00%> (+0.26%) ⬆️
...c/main/java/org/ice4j/pseudotcp/PseudoTCPBase.java 63.84% <0.00%> (-0.32%) ⬇️
...ava/org/ice4j/ice/harvest/AbstractUdpListener.java 28.57% <0.00%> (+7.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15981cf...f167f2b. Read the comment docs.

@bgrozev
Copy link
Member Author

bgrozev commented Nov 17, 2021

Tests passed as part of the JVB PR.

@bgrozev bgrozev merged commit 64a7ca8 into jitsi:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants