Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix scheduling jvb health checks. #1156

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Jun 21, 2024

Scheduling at a fixed rate leads to IO threads building up when a bridge
becomes unresponsibe and the duration of health checks becomes longer
than the health check interval.

Scheduling at a fixed rate leads to IO threads building up when a bridge
becomes unresponsibe and the duration of health checks becomes longer
than the health check interval.
@JonathanLennox
Copy link
Member

I think your solution is the same as ScheduledExecutorService.scheduleWithFixedDelay, isn't it?

@bgrozev
Copy link
Member Author

bgrozev commented Jun 21, 2024

I actually used scheduleWithFixedDelay initially but it didn't go well :)

It Submits a periodic action that becomes enabled first after the given initial delay, and subsequently with the given delay

@bgrozev
Copy link
Member Author

bgrozev commented Jun 21, 2024

Wow, I see what you mean 🤦

Scheduling at a fixed rate leads to IO threads building up when a bridge
becomes unresponsibe and the duration of health checks becomes longer
than the health check interval.
@bgrozev bgrozev merged commit 8fc38a3 into jitsi:master Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants