fix(whisper): Reconnects on socket closed while operating. #566
Conversation
Executes stop and connect in a different from the websocket messages thread as recommended in jetty docs.
damencho
force-pushed
the
ws-whisper-reconnect
branch
from
a13ce55
to
57339b2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
============================================
- Coverage 20.70% 18.89% -1.82%
- Complexity 290 294 +4
============================================
Files 76 82 +6
Lines 6313 7051 +738
Branches 838 924 +86
============================================
+ Hits 1307 1332 +25
- Misses 4787 5490 +703
- Partials 219 229 +10
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -67,7 +62,7 @@ public WhisperWebsocket getConnection(String roomId) | |||
| final WhisperWebsocket socket = new WhisperWebsocket(); | |||
|
|
|||
| // connect socket in new thread to not block Smack threads | |||
There was a problem hiding this comment.
Are we not worried about blocking Smack threads anymore? If not, update the doc :)
There was a problem hiding this comment.
It is done inside those methods.
| @@ -83,29 +78,19 @@ public WhisperWebsocket getConnection(String roomId) | |||
| public void end(String roomId, String participantId) | |||
| { | |||
| // execute this in new thread to not block Smack | |||
There was a problem hiding this comment.
It is done inside those methods.
Executes stop and connect in a different from the websocket messages thread as recommended in jetty docs.