Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DON'T MERGE YET: removed TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA cipher #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nils-ohlmeier
Copy link
Contributor

This PR removes the last DTLS ciphers which still use SHA1.

I manually verified with Wireshark that TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 successfully gets negotiated with Chrome, Firefox and Jigasi.

Note: don't merge yet as this depends on Jigasi updates in production first.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #419 (4c84f41) into master (095605d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #419      +/-   ##
============================================
- Coverage     43.33%   43.31%   -0.02%     
  Complexity      560      560              
============================================
  Files           145      145              
  Lines          5767     5765       -2     
  Branches        797      797              
============================================
- Hits           2499     2497       -2     
  Misses         2960     2960              
  Partials        308      308              
Impacted Files Coverage Δ
...rc/main/kotlin/org/jitsi/nlj/dtls/TlsClientImpl.kt 67.21% <100.00%> (-0.53%) ⬇️
...rc/main/kotlin/org/jitsi/nlj/dtls/TlsServerImpl.kt 55.00% <100.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095605d...4c84f41. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant