chore(deps) update electron to 32.1.2 #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
previously approved these changes
Sep 8, 2024
|
@saghul I found the issue of the failed mac build: The signing certificate (Developer ID Certificate) expired (its a bit hidden): Could I kindly as you to get a renewed Developer ID Certificate from 8x8 Apple Account Holder and add it to the secrets (same as 2021: #581 (comment)) |
|
Will do, thanks for the heads up! |
|
I have requested a new one. |
|
You can rebase this afetr you land the notarization update. |
Contains electron 31 and 32 update, for details see https://www.electronjs.org/blog/electron-31-0 https://www.electronjs.org/blog/electron-32-0
csett86
force-pushed
the
electron-32-0-2
branch
from
21fcf21
to
2afd9b5
Compare
csett86
changed the title
saghul
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains electron 31 and 32 update, for details see
https://www.electronjs.org/blog/electron-31-0
https://www.electronjs.org/blog/electron-32-0