Webcam starts automatically when stopping desktop screen-share #11131
Comments
|
I think this might be because we need the video track to exist but it's muted. @jallamsetty1 can you confirm? |
|
Getting the same issue here as well. Webcam light blinks for a split second when turning off the screen share. And that is a bad feeling for the user. |
Yes, we need the video track to exist and to replace the screenshare track after screenshare stops. It does get muted immediately though, no media is sent across the connection. We had to implement this to workaround a Chrome bug. |
|
Can you please add a link to the bug here, for reference? |
But from a user experience perspective, causing the webcam light to blink when it was, in fact, off, would make the users question the reliability of Jitsi. The user will think their webcam got turned on and the video was transmitted or have the feeling of a photo being snapped. |
|
The alternative is to have video stop working altogether. |
|
@saghul @jallamsetty1 I think it’s a Major privacy issue as per me… I was in a meeting with the remote participant sharing his screen after some time he stopped his screen share… I was able to see his video for 1 sec.!!! which describes a privacy issue right? his intention was not to TURN the video ON but without a user click video is turning ON. |
|
@saghul @jallamsetty1 Can we have a separate track for Video and Screenshare? |
This issue will be gone with multi-stream mode that we currently have in development. We hope to release the new mode in a couple of weeks. |
We know. Have you read my previous comment? |
|
@saghul You mean we should not give permission for video right? |
|
No I mean that without the workaround video would stop working altogether. It will stop happening when we release multi-stream support. |
jallamsetty1
added a commit
to jallamsetty1/jitsi-meet
that referenced
this issue
Mar 29, 2022
…stops instead of not adding the track." This workaround is not needed anymore since P2P is disabled between plan-b and unified-plan clients. Fixes jitsi#11131 This reverts commit c300382.
jallamsetty1
added a commit
to jallamsetty1/jitsi-meet
that referenced
this issue
Mar 30, 2022
…stops instead of not adding the track." This workaround is not needed anymore since P2P is disabled between plan-b and unified-plan clients. Fixes jitsi#11131 This reverts commit c300382.
pull bot
pushed a commit
to e4basil/jitsi-meet
that referenced
this issue
Mar 30, 2022
…stops instead of not adding the track." This workaround is not needed anymore since P2P is disabled between plan-b and unified-plan clients. Fixes jitsi#11131 This reverts commit c300382.
This was referenced Apr 5, 2022
Closed
Closed
Merged
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
May 6, 2022
jitsi-meet 1.0.6091 ----------- * fix(stageFilmstrip) Disable stage filmstrip by default. * fix(start-silent) Disable AOT mic and unmute notif when start silent * fix(lang) update Italian translation * chore(deps) lib-jitsi-meet@latest * fix: Skips clearing tracks on conference failed. * fix(multi-stream) update screenshare display name (#11376) * feat(reactions) Open reactions menu on hover instead of click (#11364) * misc(rn,app) log navigation target * feat(participants-pane/native) adjusted styles for when local p is not a moderator (#11349) * fix(security) hide button if the enabled flag is set to false * fix(rn,config) fix loading config due to broken import * fix(stage-filmstrip) Fix issues (#11360) * fix: Adds testId for context menu items and ids to some components. * Revert "fix(avatar): add ZWNJ between initials of letter avatars" * chore(deps) lib-jitsi-meet@latest * fix(avatar): add ZWNJ between initials of letter avatars * chore(rn,deps) react-native-default-preference@1.4.4 * feat(rtc-stats) add timestamp to face landmarks when sending to rtc stats * fix(lang) update German translation * chore(deps): bump moment from 2.29.1 to 2.29.2 * fix(multi-stream) use highest video quality for screenshare * fix(multi-stream) fix screenshare auto pin bug * fix(ios) fix not marking speaker as a selected device * fix(ios) avoid reapplying config when audio category doesn't change * fix(ios) fix not showing the CarPlay audio interface * chore(deps) lib-jitsi-meet@latest * language(typescript) actionTypes.js -> actionTypes.ts (#10940) * fix(android) fix crash when starting foreground service * feat(face-landmarks) add API event for providing face landmark data (#11347) * fix(multi-stream) only create local ss particpant with multi-stream enabled * fix(ios,broadcast-extension) remove unused import * feat(chat/web) fixed 2 byte char duplication (#11332) * fix(face-landmarks): get face models from node_modules instead of having resoruces folder (#11326) * chore(deps) lib-jitsi-meet@latest (#11336) * fix(speaker-stats): get realtime local face expressions (#11334) * chore(ios) sync Podfile.lock * feat(conference/native) - hide label in one to one meeting * fix(rn) remove no longer needed hack * feat(rn,deps) update React Native to 0.67 * chore(deps) react-native-reanimated@1.13.4 * fix(rn,polyfills) remove no longer needed polyfill * feat(stage-filmstrip) Added user configurable max (#11324) * fix: Adds undefined check to avoid error. * ref(face-landmarks) refactor namings (#11307) * fix: leaking listeners while waiting on auth dialog (#11288) * fix(lang) update Portuguese Translation * fix(multi-stream) support screenshare tile in stage filmstrip * fix(lang) update Russian translation * fix(follow-me) Make follow me work with stage filmstrip (#11306) * ref(overflow-menu) Use ContextMenu component (#11282) * chore(deps) npm audit fix * chore(deps) lib-jitsi-meet@latest * fix(conference) Do not add audio track from screenshare to redux. In audio-only screenshare mode when there is no local audio track from mic present, do not add the audio track from screenshare to redux. Adding the track to redux will sync the track mute state to that of /base/media and show that the mic is unmuted even when that is not the case. Fixes jitsi/jitsi-meet#10706. * feat(multi-stream) Whitelist config flags for multi-stream. * feat(multi-stream) Add fake participant tile for screen share. * chore(deps) update react-native-webrtc to 1.100.0 * chore(rn,versions) bump app and sdk versions * feat(face-landmarks) merge face expressions and face centering (#11283) * fix(filmstrip) Fix resizing on chat toggle (#11305) * feat(participants-pane/native) adjusted styles for participants container * ref(AOT) Change buttons to not use abstract classes (#11302) * fix(highlights) allow highlighting moments if recording is running (#11301) * fix(lang) updated Arabic translation * fix(lang): update french translation * feat(multi-stream) Update config.js. * feat(polls/web) fixed issue with duplicating value to next input on keypress * Pushes e2e pings to rtcstats (#11270) * Fixes for highlights mobile (#11209) * fix(large-video) Show the pinned participant on large-video when stage filmstrip is disabled. Fixes an issue where a non-screenshare participant cannot be pinned on stage with filmstrip on stage feature disabled. * feat(android) use JitsiMeetView instead of JitsiMeetFragment * chore(deps) lib-jitsi-meet@latest (#11284) * fix(salesforce) use salesforce only in the main room (#11245) * fix(ci) make the "dirty git tree" CI failure clearer * feat(rn, thumbnail) Updated indicators on native (#11280) * fix(thumbnails) Fix recalculate tile dimensions on client resize (#11267) * chore(deps): bump minimist from 1.2.5 to 1.2.6 * chore(deps): bump ansi-regex from 3.0.0 to 3.0.1 in /resources/load-test * chore(deps): bump ansi-regex from 4.1.0 to 4.1.1 * chore(deps): bump plist from 3.0.4 to 3.0.5 * fix(ios) cycle in dependancies with Xcode 13.3 * feat(ios) enable Dropbox recording * Update Portuguese translation * chore(deps) lib-jitsi-meet@latest * fix(notifications) Change moderation notifications to medium (#11262) * feat(gif, rn) Added GIPHY integration on native (#11236) * fix(gif) Keep showing GIF on hover (#11266) * fix(context-menu) Don't overwrite hidden prop (#11265) * chore(deps): bump node-forge from 1.2.1 to 1.3.0 * Add missing key to Persian lang file * feat: Updates external-services.lua to latest. * Revert "fix(screenshare) Add and then mute the camera track after SS stops instead of not adding the track." This workaround is not needed anymore since P2P is disabled between plan-b and unified-plan clients. Fixes jitsi/jitsi-meet#11131 * fix(background-alpha) Fix setting background opacity * fix(video-layout) fix incorrect import of isStageFilmstripEnabled * fix(rn,lobby) fix lobby not showing up on subsequent tries * fix(settings-dialog) Add back CSS classes used by tests * fix(android,back-button) rework back button handling on Android * feat(participants/native) - fix joining breakout room * fix(rn) Fix native after stage filmstrip merge (#11247) * refactor(connection-stats): use jss instead of sass in ConnectionStatsTable (#11156) * refactor(virtual-background): use jss instead of sass (#11152) * refactor: move chat component outside of videoconference_page (#11138) * refactor(dialog): use jss instead of sass for mute-dialog style (#11154) * refactor(settings): use jss instead of css (#11149) * feat(stage) Add stage filmstrip (multiple participants on stage) (#11145) * feat: Adds a hint for cors headers in default prosody config. * fix(redux) fix not working with Redux Devtools * fix(debian) support installing the prosody-0.12 upstream package * fix(face-centering) fix face centering on browsers with no offscreencanvas support (#11234) * fix(lang): update french translation * chore(deps) lib-jitsi-meet@latest * fix(rn,recording) fix recording dialog state not updating * Increase the visibility of 404 error message (#11108) * fix(highlight) set highlight button visibility based on record button? (#11215) * fix(highlight) implement custom notification for highlight start recording (#11217) * fix(facial-expressions): base url for models (#11218) * fix(lang) update Dutch translation * feat(participants/native) - updated container styles * fix(rn,recording) fix start button not being enabled * feat(reservations) add integration with mod_muc_max_occupants * conf(nginx) add keepalive via upstream groups * fix(overlay) fix not showing the correct gUM helper text * fix(lobby) display the entire message in the reject notification * fix(mobile/navigation) - fixed bottom color glitch * chore(deps) lib-jitsi-meet@latest * feat(external-api) Add grantModerator command (#11199) * chore(deps) lib-jitsi-meet@latest * Update config.js with new e2eping properties. (#11195) * fix(chat) Fix iOS web chat (#11193) * fix(mobile,navigation) remove end meeting page * fix(mobile/navigation/sdk) - simplified check for sdk * fix(settings-dialog) Fix crash (#11191) * refactor(premeeting): remove redundant styles from prejoin.scss (#11151) * fix(shared-video): Can't click controls issue * chore(deps) lib-jitsi-meet@latest * task: mod_muc_password_whitelist prosody module (#11184) * fix: removed platformColor from styles * fix(highlight) fix notifications not disappearing (#11183) * patch(react-native-dialog)- replaced PlatformColor with hardcoded colors on Android * add(highlights): mobile flow (#11168) * fix(recording) fix incorrect condition for recording notification message (#11167) * fix(highlight) display option to start recording (#11146) * fix(config): add missing toolbar button config (#11165) * fix(css) remove no longer used AUI classes * fix(mobile/navigations) added LoadConfigOverlay to RootNavigator (#11067) * fix(ios,build) use epoch seconds for build number * feat: Use same recommendedBrowsers page for IE and browsers marked in interface_config.js (#10923) * fix(video-constraints) Fix calculations (#11161) * fix(salesforce): send link notes and default to empty string (#11160) * fix(resziable-filmstrip) Update video constraints on filmstrip resize (#11150) * fix(premeeting): fix undefined breakpoint in media query (#11148) * Revert "deps(rn) react-native-webrtc@1.98.0" * fix(premeeting): call hooks before any conditional block in ConnectionStatus (#11136) * feature: patch for muc_owner_allow_kick in prosody 0.12 (#11142) * feat(filmstrip): Don't reorder in small meetings. * chore(deps) lib-jitsi-meet@latest * fix(config) add missing notify.hostAskedUnmute * feat(multi-stream-support) Add screenshare as a second video track to the call. * chore(deps) lib-jitsi-meet@latest * fix(resizable-filmstrip): grid view paddings. * feat(tile-view): Optimize grid dimnsions. * add(screenshot-capture): local participants id to participants array in metadata (#11134) * fix(lang) update french translation * fix(screenshot-capture): send remote participant id instead of jid (#11132) * refactor(prejoin) use jss instead of sass in DialInDialog (#11122) * refactor(participnats-pane) move participant-avatar to commmonStyles (#11120) * refactor(premeeting): use jss instead of sass in ConnectionStatus (#11115) * refactor(prejoin) use jss instead of sass in CallingDialog (#11117) * fix(lang) update Arabic translation * refactor(speaker-stats) use jss instead of sass in SpeakerStats (#11121) * refactor(prejoin) use jss instead of sass in DeviceStatus (#11116) * refactor(avatar) use jss instead of scss (#11037) * chore: remove unused modal ids constants (#11036) * refactor(keyboard-shortcuts) use jss instead of scss * fix(highlight) fix allowing disabled button to execute handler (#11128) * feat(remote-participant-menu) Enhance remote participant menu: * fix: Hides ask to unmute when participant is audio unmuted. * fix: Hides ask to unmute when av mod is disabled. Fixes #11057. * fix(filmstrip) Fix resizable filmstrip with shared video (#11124) * feat(recording) allow highlighting meeting recording moments (#10981) * feat(toolbar) add flag for autohiding while chat open (#11104) * fix(lang) update Portuguese translation * Fix broken link in README.md to the handbook * feat(gif) Added GIF support (GIPHY integration) (#11021) * fix(lang) update Arabic translation * fix(letsencrypt) avoid using hardcoded path * fix(prejoin) Fix layout on reduced height * fix(screensharing) Fix screensharing container width (#11089) * fix: Updates token verification hooks priority. (#11105) * fix(dynamic-branding) fix permissions screen not accounting for custom backgrounds (#11097) * feat(recording) mobile and web ui updates * fix(language) Add lang API option * chore(rn,versions) bump app versions * deps(rn) react-native-webrtc@1.98.0 * feat(display-name) remove DisplayNameLabel web * feat(salesforce) - link resources to the current session (#10992) * fix(conference) Disable audio-only mode when user switches to screenshare. Make the behavior consistent with enabling camera when the user is audio-only mode. Also fixes an issue where the screenshare preview doesn't appear if it is enabled while the user is in audio-only mode. * fix(lang) update German translation * fix(video-layout):Screenshares not updated on time * feat(face-centering) implement centering of faces in a video * fix(dominant-label) Fix dominant speaker stage view label (#11071) * fix(rn,dialogs,auth) fix not showing authentication dialogs * feat: Lobby chat (#10847) * fix(premeeting): Improve pre-meeting responsiveness for screens less than 1000px * fix(popper): resolve @atlaskit/popper to an unbuggy version * fix(dynamic-branding): Extract fqn from public meeting ****************************************************************** lib-jitsi-meet ----------- * fix: Cleanups JitsiConference on reservation and max user failures. @damencho (#1986) * fix(video-quality) Update frame heights in content-modify for p2p. (#1983) * fix(BridgeChannel): re-send constraints and videoType message after every re-connect. This fixes an issue where the receiver constraints and video type messages are sent on the bridge channel only the first time the ws conn gets re-established. * fix: p2p reject reason (#1840) * fix(presence) Only apply default videoType on video tracks * fix(presence): send presence update when a local track is removed. When a screenshare track is removed in the legacy mode, presence needs to be sent with the muted state and videoType so the remote gets updated. * ref(face-expressions) refactor face landmarks namings (#1977) * fix(presence) Parse peer presence in legacy format correctly. When source-name signaling is enabled, get correct peermedia info when the peer sends presence in the legacy format. This fixes an issue where Jigasi users cannot be heard by endpoints that have source-name signaling enabled. * Plumbing for e2e pings. (#1973) * fix(BreakoutRooms) fix checking for isBreakoutRoom early * fix(multi-stream) fix p2p issues with secondary video sources. * chore(deps): bump minimist from 1.2.5 to 1.2.6 * fix(SDP) fix unit test for LocalSdpMunger. * fix(conference) Disable p2p between eps running in different SDP modes. Disable p2p between endpoints that are not running in the same SDP mode. The source-add/source-remove handlers assume the mids to follow the same pattern on both self and peer but the mids generated in plan-b mode are different from unified plan mode. Fixes jitsi/jitsi-meet#11100. * fix(multi-stream) Update the <ssrc, source-name> map for p2p as well. * fix(SDP) Always modify the streamId part of msid when source-name signaling enabled. Do this even if the browser provides a non '-' string for streamId since we rely on this to generate the source name. * fix: Set affiliation. (#1966) * fix(multi-stream) Handle source-name based presence updates. Handle presence updates for multiple sources per remote endpoint. * fix(multi-stream) Add default presence for camera tracks in source-name signaling. Also switch to using signalingLayer.getPeerSourceInfo during remote track creation when source-name signaling is used. * fix(multi-stream) Reject m-lines associated with removed sources. We do not want the client to re-use the inactive transceivers that are associated with m-lines for removed remote tracks. Rejecting a m-line on source-remove clears it from the list of available transceivers. * fix(SDP) Extract the stream id from msid for source-name generation. * fix(multi-stream) Do not init ParticipantConnectionStatusHandler when source-name signaling is enabled. * fix(TPC) Send presence before signaling for SS tracks. This is needed for the track to be identified as a desktop track on the remote peer when the JitsiRemoteTrack is created. Fixes jitsi/lib-jitsi-meet#1649. * fix(multi-stream) Add video tracks sequencially. If there are more than one video track at pc creation time, add them sequencially to avoid renegotiation loop. * fix(TPC) Update the local SSRC cache when a track is replace with another. Fixes an issue where the local stats are not emitted in Unified plan after a track replace. * feat: End-to-end ping updates (#1961) * fix(multi-stream) Check if the flags config options is defined. * fix(multi-stream-support) Support muting of desktop track. * chore(build) remove unneeded code * feat(ts) typescript conversion of MediaDirection * feat(ts) convert service/statistics/constants to typescript * fix(build) use path.join in webpack-shared.config * fix(build,ts) clean before building * chore(cleanup) remove unused code * typescript conversion of service/RTC/VideoType to named export * typescript implementation of JitsiTrackEvents
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this issue
May 7, 2022
…stops instead of not adding the track." This workaround is not needed anymore since P2P is disabled between plan-b and unified-plan clients. Fixes jitsi#11131 This reverts commit c300382.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
The video cam is automatically turned on and turned off after stopping desktop screen-share. Webcam flashlight blinks for around 2 seconds.
Steps to reproduce:
Expected behavior:
Either webcam shouldn't start when stopping screen share or flashlight.
Actual behavior:
Webcam start and blinks for around 2 seconds.
Server information:
Client information:
Additional information:
This issue was not found in the previous version.
This issue exist in https://meet.jit.si/
The text was updated successfully, but these errors were encountered: