fix: volume slider min width so not squashed when lonely #10808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! |
robertpin
suggested changes
Jan 19, 2022
robertpin
approved these changes
Jan 19, 2022
yanas
pushed a commit
that referenced
this pull request
Jan 19, 2022
This was referenced Apr 5, 2022
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volume slider currently takes the width of the popup menu on remove video. This is a problem in the case of non-moderator users when chat feature is disabled -- there are no other menu items to push out the width and slider ends up unusably small.
See: https://community.jitsi.org/t/squashed-volume-slider-for-non-moderator-if-chat-disabled/110275?u=shawn
This PR addresses this by ensuring volume slider has a minimum width.