feat(recording) allow highlighting meeting recording moments #10981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Feb 17, 2022
quitrk
force-pushed
the
tavram/bookmark
branch
2 times, most recently
from
208cb46 to
07471fe
Compare
quitrk
changed the title
|
jenkins please test this please |
quitrk
force-pushed
the
tavram/bookmark
branch
2 times, most recently
from
1df499b to
81d136d
Compare
quitrk
changed the title
quitrk
changed the title
saghul
approved these changes
Mar 11, 2022
| export function _abstractMapStateToProps(state: Object) { | ||
| const isRecordingRunning = getActiveSession(state, JitsiRecordingConstants.mode.FILE); | ||
| const isButtonDisabled = isHighlightMeetingMomentDisabled(state); | ||
| const { webhookProxyUrl } = state['features/base/config']; |
There was a problem hiding this comment.
Oh, this one is not documented in config.js (not your fault)
coming in a future PR |
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.