Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resziable-filmstrip) Update video constraints on filmstrip resize #11150

Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix(resziable-filmstrip) Update video constraints on filmstrip resize #11150

merged 1 commit into from
Mar 16, 2022

Conversation

robertpin
Copy link
Contributor

No description provided.

quitrk
quitrk previously approved these changes Mar 16, 2022
@jallamsetty1
Copy link
Member

@robertpin Can you also pls recalculate the maxHeight for the participant on stage in stage view ? When the filmstrip is resized, the client should request lower resolution for the participant on stage based on the tile size instead of 2160.

@jallamsetty1
Copy link
Member

@robertpin Forgot to add that screenshare sources are an exception here. If the source on stage is a screenshare, then the client should continue to request max height of 2160.

@robertpin robertpin merged commit 7bcf7bb into jitsi:master Mar 16, 2022
@robertpin robertpin deleted the rpintilii/resizable-filmstrip-video-constraints branch March 16, 2022 14:57
ankit-programmer pushed a commit to ankit-programmer/jitsi-meet that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants