-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(face-landmarks) merge face expressions and face centering #11283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
requested changes
Apr 1, 2022
quitrk
force-pushed
the
tavram/workers
branch
3 times, most recently
from
April 1, 2022 12:18
88172f7
to
832b6a4
Compare
quitrk
changed the title
[wip] merge face recognition workers
feat(face-landmarks) merge face expressions and face centering
Apr 1, 2022
@gabiborlea can you pl review too? |
gabiborlea
suggested changes
Apr 4, 2022
gabiborlea
approved these changes
Apr 4, 2022
@saghul seems to be fine |
saghul
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small question.
Jenkins please test this please |
pull bot
pushed a commit
to e4basil/jitsi-meet
that referenced
this pull request
Apr 4, 2022
…#11283) * feat(face-landmarks) merge face expressions and face centering * code review * code review * code review
Merged
This was referenced Apr 5, 2022
Closed
Closed
Merged
ankit-programmer
pushed a commit
to ankit-programmer/jitsi-meet
that referenced
this pull request
May 7, 2022
…#11283) * feat(face-landmarks) merge face expressions and face centering * code review * code review * code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.