Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set blurred background from external api #15131

Conversation

Razor1700
Copy link
Contributor

Add setBlurredBackground command to external api

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the UI there are two types of blur effects, maybe the function needs to be parametrized to be able to achieve that, wdyt?

conference.js Outdated Show resolved Hide resolved
@Razor1700
Copy link
Contributor Author

In the UI there are two types of blur effects, maybe the function needs to be parametrized to be able to achieve that, wdyt?

I don't need it at the moment but it could be an interesting feature. I'll add it when moving the code into virtual-background

@Razor1700 Razor1700 force-pushed the feature-request/set-blurred-background-from-external-api branch 2 times, most recently from 9aa4e65 to 8c8573c Compare September 19, 2024 09:03
@Razor1700
Copy link
Contributor Author

Razor1700 commented Sep 19, 2024

Parameter to choose blur type added to the method

Copy link
Member

@damencho damencho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I didn't express my self correctly the previous time, we try to remove code out of conference.js and to avoid adding stuff there.

conference.js Outdated Show resolved Hide resolved
Add setBlurredBackground command to external api.
@Razor1700 Razor1700 force-pushed the feature-request/set-blurred-background-from-external-api branch from 8c8573c to 02aebd7 Compare September 20, 2024 11:56
@Razor1700
Copy link
Contributor Author

Maybe I didn't express my self correctly the previous time, we try to remove code out of conference.js and to avoid adding stuff there.

Oh ok sorry for the misunderstanding. I remove everything from conference.js

@damencho
Copy link
Member

Jenkins, test this please.

@damencho
Copy link
Member

LGTM. @Razor1700 Would you mind creating a PR adding it to the docs page here: https://github.com/jitsi/handbook/blob/master/docs/dev-guide/iframe-commands.md

Thank you for your contribution.

@damencho damencho merged commit 97930bf into jitsi:master Sep 20, 2024
10 checks passed
@Razor1700
Copy link
Contributor Author

Razor1700 commented Sep 20, 2024

No problem, I'll update the doc
PR done : jitsi/handbook#527

@Razor1700 Razor1700 deleted the feature-request/set-blurred-background-from-external-api branch September 20, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants