feat(tests): Adds avatar test. #15382
Open
+956
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was succesfully scanned and it was determined that it does not contain any changes that present immediate security concerns. If you would still like for it to be reviewed by an expert from our reviewer community, you can submit it manually via the HackerOne PullRequest dashboard
saghul
reviewed
Dec 12, 2024
| const avatar | ||
| = this.driver.$('//span[@id="localVideoContainer"]//img[contains(@class,"userAvatar")]'); | ||
|
|
||
| return await avatar.isExisting() ? await avatar.getAttribute('src') : null; |
There was a problem hiding this comment.
Suggested change
| return await avatar.isExisting() ? await avatar.getAttribute('src') : null; | |
| return await (avatar.isExisting() ? avatar.getAttribute('src') : null); |
| * Returns resource part of the JID of the user who is currently displayed in the large video area. | ||
| */ | ||
| async getLargeVideoResource() { | ||
| return this.driver.execute(() => APP.UI.getLargeVideoID()); |
| @@ -182,6 +183,7 @@ | |||
| "jsonwebtoken": "9.0.2", | |||
| "metro-react-native-babel-preset": "0.77.0", | |||
| "patch-package": "6.4.7", | |||
| "pretty": "2.0.0", | |||
There was a problem hiding this comment.
Is this really necessary? "2.0.0 • Public • Published 8 years ago" seems unmaintained and it only makes HTML more readable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.