feat(recordings) add consent dialog #15673
Open
+151
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihhu
force-pushed
the
recording-consent
branch
from
5c6cf47 to
f758f6b
Compare
saghul
reviewed
Feb 27, 2025
react/features/recording/components/Recording/native/RecordingConsentDialog.tsx
Outdated
Show resolved
Hide resolved
| const { requireRecordingConsent } = getState()['features/dynamic-branding']; | ||
|
|
||
| if (!requireRecordingConsent | ||
| && (recorderSession._statusFromJicofo === JitsiRecordingConstants.status.OFF |
There was a problem hiding this comment.
Is there not better way to check? Maybe we need a helper to encapsulate these weird checks?
| * @returns {void} | ||
| */ | ||
| function _showExplicitConsentDialog(recorderSession: any, dispatch: IStore['dispatch'], getState: IStore['getState']) { | ||
| const { requireRecordingConsent } = getState()['features/dynamic-branding']; |
There was a problem hiding this comment.
No config? Sounds like something more prople might want to use?
mihhu
force-pushed
the
recording-consent
branch
from
f758f6b to
dc15f4f
Compare
mihhu
force-pushed
the
recording-consent
branch
from
dc15f4f to
854dc8d
Compare
saghul
approved these changes
Feb 28, 2025
Calinteodor
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.