-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cryptex. #1969
Support cryptex. #1969
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1969 +/- ##
============================================
- Coverage 43.10% 43.02% -0.08%
+ Complexity 1668 1667 -1
============================================
Files 322 323 +1
Lines 16691 16721 +30
Branches 2192 2200 +8
============================================
+ Hits 7194 7195 +1
- Misses 8788 8824 +36
+ Partials 709 702 -7
Continue to review full report at Codecov.
|
I marked this as "ready for review" but we still need the AudioLevelReader split. |
@@ -771,6 +773,9 @@ class Endpoint @JvmOverloads constructor( | |||
} else { | |||
logger.info("Ignoring empty DtlsFingerprint extension: ${transportInfo.toXML()}") | |||
} | |||
if (CryptexConfig.endpoint) { | |||
cryptex = cryptex || fingerprintExtension.cryptex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be &&
now? Otherwise it's just equivalent to the config value. The semantics of Endpoint.cryptex
is "whether we should use cryptex when encrypting", right?
Supports draft-ietf-avtcore-cryptex. Part of a package with jitsi/jitsi-srtp#29, jitsi/lib-jitsi-meet#2150, and jitsi/jitsi-xmpp-extensions#87.