fix(quality) Sends updated receiver constraints.

Fixes a regression for JitsiConference::setReceiverVideoConstraint and JitsiConference::setAssumedBandwidthBps.
jitsi · Nov 5, 2024 · 0ef8314 · 0ef8314
1 parent c280c0e
commit 0ef8314
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/modules/RTC/RTC.js b/modules/RTC/RTC.js
@@ -305,7 +305,7 @@ export default class RTC extends Listenable {
             return;
         }
 
-        this._receiverVideoConstraints = constraints;
+        this._receiverVideoConstraints = cloneDeep(constraints);
 
         if (this._channel && this._channel.isOpen()) {
             this._channel.sendReceiverVideoConstraintsMessage(constraints);

diff --git a/modules/qualitycontrol/ReceiveVideoController.js b/modules/qualitycontrol/ReceiveVideoController.js
@@ -74,14 +74,15 @@ export default class ReceiveVideoController {
     /**
      * Updates the source based constraints based on the maxHeight set.
      *
+     * @param {number} maxFrameHeight - the height to be requested for remote sources.
      * @returns {void}
      */
-    _updateIndividualConstraints() {
+    _updateIndividualConstraints(maxFrameHeight) {
         const individualConstraints = this._receiverVideoConstraints.constraints;
 
         if (individualConstraints && Object.keys(individualConstraints).length) {
             for (const value of Object.values(individualConstraints)) {
-                value.maxHeight = Math.min(value.maxHeight, this._maxFrameHeight);
+                value.maxHeight = maxFrameHeight ?? Math.min(value.maxHeight, this._maxFrameHeight);
             }
         } else {
             this._receiverVideoConstraints.defaultConstraints = { 'maxHeight': this._maxFrameHeight };
@@ -184,7 +185,7 @@ export default class ReceiveVideoController {
             if (session.isP2P) {
                 session.setReceiverVideoConstraint(this._getDefaultSourceReceiverConstraints(session, maxFrameHeight));
             } else {
-                this._updateIndividualConstraints();
+                this._updateIndividualConstraints(maxFrameHeight);
                 this._rtc.setReceiverVideoConstraints(this._receiverVideoConstraints);
             }
         }