fix(JingleSession) Get correct direction for source-remove on p2p.

jitsi · Oct 30, 2024 · 9eefac1 · 9eefac1
1 parent d51e557
commit 9eefac1
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/modules/xmpp/JingleSessionPC.js b/modules/xmpp/JingleSessionPC.js
@@ -400,9 +400,11 @@ export default class JingleSessionPC extends JingleSession {
             for (const mid of modifiedMids) {
                 if (this.isP2P) {
                     const { media } = SDPUtil.parseMLine(currentRemoteSdp.media[mid].split('\r\n')[0]);
-                    const desiredDirection = this.peerconnection.getDesiredMediaDirection(media, true);
+                    const desiredDirection = this.peerconnection.getDesiredMediaDirection(media, isAdd);
+                    const currentDirections = isAdd ? [ MediaDirection.RECVONLY, MediaDirection.INACTIVE ]
+                        : [ MediaDirection.SENDRECV, MediaDirection.SENDONLY ];
 
-                    [ MediaDirection.RECVONLY, MediaDirection.INACTIVE ].forEach(direction => {
+                    currentDirections.forEach(direction => {
                         currentRemoteSdp.media[mid] = currentRemoteSdp.media[mid]
                             .replace(`a=${direction}`, `a=${desiredDirection}`);
                     });