Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2ee: add unit tests #1346

Merged
merged 1 commit into from
Oct 2, 2020
Merged

e2ee: add unit tests #1346

merged 1 commit into from
Oct 2, 2020

Conversation

fippo
Copy link
Member

@fippo fippo commented Oct 1, 2020

Both for just encode function as well as an end-to-end test.

@saghul
Copy link
Member

saghul commented Oct 1, 2020

❤️

@fippo
Copy link
Member Author

fippo commented Oct 1, 2020

   SyntaxError: /home/runner/work/lib-jitsi-meet/lib-jitsi-meet/modules/e2ee/Context.js: Identifier directly after number (60:27)
    58 |         // Must be incremented on every frame that is sent, can be reset on
    59 |         // key changes.
  > 60 |         this._sendCount = 0n;

That is an odd failure. This line isn't even in the change? Updated to use BigInt instead

@fippo fippo force-pushed the e2ee-e2e-tests branch 3 times, most recently from eb2b11f to 6343419 Compare October 2, 2020 06:49
Both for just encode function as well as an end-to-end test.
* - frame header is not encrypted
* - different sendCounts
* - different key length
* - ratcheting in decodeFunction
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a test for this but there should be a test for "it errors when running out of window" :-)

@fippo fippo merged commit 666f100 into master Oct 2, 2020
@fippo fippo deleted the e2ee-e2e-tests branch October 2, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants