Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TPC) add muted tracks if p2p is disabled (fix #1851) #1857

Merged
merged 1 commit into from
Feb 9, 2022
Merged

fix(TPC) add muted tracks if p2p is disabled (fix #1851) #1857

merged 1 commit into from
Feb 9, 2022

Conversation

NewEraCracker
Copy link
Contributor

@NewEraCracker NewEraCracker commented Jan 21, 2022 •
edited
Loading

Fixes #1851. Please review.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@sapkra sapkra mentioned this pull request Feb 6, 2022
Merged
@sapkra sapkra added the bug Generic issue label Feb 6, 2022
@alan-albuquerque
Copy link

hi, any news on that?

@jallamsetty1
Copy link
Member

This fix will not work since we do not want to signal muted sources to Jicofo. I am out today, will take a look at the issue tomorrow.

@jallamsetty1
Copy link
Member

Jenkins test this please.

@jallamsetty1
Copy link
Member

I was wrong, actually this fix will work. Muted source will only be signaled for the first user that mutes themselves after joining the call and before the peer joins. The other alternative would be to force renegotiation on every unmute which is not desirable. Thanks @NewEraCracker for the fix and the PR.

@jallamsetty1
Copy link
Member

@NewEraCracker Can you please rebase your branch ? The build is failing since we have made some changes recently to the way we build LJM.

@jallamsetty1
Copy link
Member

Jenkins test this please.

@jallamsetty1 jallamsetty1 merged commit 37008a3 into jitsi:master Feb 9, 2022
@NewEraCracker NewEraCracker deleted the pr-issue-1851 branch February 10, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jallamsetty1 jallamsetty1 jallamsetty1 approved these changes

Assignees
No one assigned
Labels
bug Generic issue
Projects
None yet
Milestone
No milestone
5 participants
@NewEraCracker @jitsi-jenkins @alan-albuquerque @jallamsetty1 @sapkra