Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] store the credentials user input as a ViewController field and skip the dialog #6

Open
dodikk opened this issue Jul 27, 2018 · 2 comments

Comments

@dodikk
Copy link

dodikk commented Jul 27, 2018

A heads-up to the future library users.

In my case the web page contains a video playback link.
Both the page and the video are hosted as corporate resources and require the ADFS authorization.
When the video playback starts, the user is overwhelmed with the "please enter credentials" alerts.

P.S. That's pretty easy to fix. No library modification is required. It affects only the demo project code. I'll send a pull request addressing this issue soon.

dodikk pushed a commit to dodikk/JiveAuthenticatingHTTPProtocol that referenced this issue Jul 27, 2018
@dodikk
Copy link
Author

dodikk commented Jul 27, 2018

Added memoization in #7

@hborders
Copy link
Collaborator

This is a fine refactor. Making the example more fully functional is great!

dodikk pushed a commit to dodikk/JiveAuthenticatingHTTPProtocol that referenced this issue Jul 30, 2018
dodikk pushed a commit to dodikk/JiveAuthenticatingHTTPProtocol that referenced this issue Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants