Update error message when no movement target is found. #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
feb66f0 to
379b33b
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
3 times, most recently
from
f067ef5 to
6ecc2da
Compare
essiene
changed the title
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
from
1a73a47 to
2fcbb68
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
2 times, most recently
from
62c0187 to
75b7379
Compare
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
from
2fcbb68 to
43c3e3f
Compare
martinvonz
previously approved these changes
Aug 16, 2024
martinvonz
reviewed
Aug 16, 2024
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
75b7379 to
7058399
Compare
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
2 times, most recently
from
92730f0 to
63d516b
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
7058399 to
100991e
Compare
martinvonz
dismissed
their stale review
Undoing approval until we've figured out what to do about commits with more than 1 parent
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
from
63d516b to
c534c21
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
100991e to
e395474
Compare
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
from
c534c21 to
e76ec87
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
e395474 to
9ea300d
Compare
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
2 times, most recently
from
944bd6a to
d0c7cc3
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
9ea300d to
c513edf
Compare
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
from
d0c7cc3 to
2661065
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
c513edf to
c3bf86e
Compare
essiene
force-pushed
the
essiene/push-pmsvoxtkupkp
branch
from
80cf4d2 to
666be54
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
9957ca5 to
eb78142
Compare
essiene
force-pushed
the
essiene/push-pmsvoxtkupkp
branch
from
666be54 to
41714af
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
eb78142 to
0dde77f
Compare
essiene
force-pushed
the
essiene/push-pmsvoxtkupkp
branch
from
41714af to
7173dd9
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
0dde77f to
c639970
Compare
essiene
force-pushed
the
essiene/push-pmsvoxtkupkp
branch
from
7173dd9 to
f0d6c53
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
c639970 to
09535dc
Compare
essiene
changed the base branch from
essiene/push-pmsvoxtkupkp
to
essiene/push-utlmxzpwopxr
essiene
force-pushed
the
essiene/push-utlmxzpwopxr
branch
2 times, most recently
from
429d9e9 to
3742158
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
09535dc to
b5cbfaa
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
3 times, most recently
from
9c9da31 to
3a3d234
Compare
yuja
reviewed
Aug 23, 2024
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
3 times, most recently
from
1d8e082 to
fe7a206
Compare
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
3 times, most recently
from
1c3b69e to
3bd14c8
Compare
If movement commands don't find a target commit, they fail. However, it's usually not intuitive why they fail because in non-edit mode the start commit is the parent of the working commit. Adding the start commit change hash to the error message makes it easier for the user to figure out what is going on. Also, specifying 'No **other** descendant...' helps make it clear what `jj` is really looking for. Part of #3947
essiene
force-pushed
the
essiene/push-psqruoxnkoyy
branch
from
3bd14c8 to
30c4a88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If movement commands don't find a target commit, they fail. However,
it's usually not intuitive why they fail because in non-edit mode the
start commit is the parent of the working commit.
Adding the start commit change hash to the error message makes it easier
for the user to figure out what is going on.
Part of #3947
Checklist
If applicable:
CHANGELOG.md