Build Nix flake checks in test mode
#5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoughtpolice
force-pushed
the
aseipp/push-lstzunxprqtv
branch
3 times, most recently
from
430a747 to
eb0728f
Compare
ilyagr
reviewed
Jan 27, 2025
ilyagr
reviewed
Jan 27, 2025
ilyagr
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
I'm mostly approving this based on the CI, in the hopes it will decrease flakyness. We can revert things if they don't work. Or, if some more Nix-y person wants to review this before it's merged, please leave a comment.
I also did check that nix flake check, nix build, and nix shell work with this, though I'm not sure how optimized they are.
bryceberger
reviewed
Jan 28, 2025
thoughtpolice
force-pushed
the
aseipp/push-lstzunxprqtv
branch
from
eb0728f to
971910e
Compare
Some of our builds have been timing out, and one angle I want to look at is whether any tests are hanging. Nextest can help us keep track of slow tests in CI where the underlying hosts will have significantly higher load. In general this should also help keep our tests healthy, IMO. I don't see any reason why any existing test should take over 20 seconds, but it should at least help control for really slow runners that have huge latency spikes. we can start there and see how it goes in practice. Signed-off-by: Austin Seipp <aseipp@pobox.com>
This should help reduce time spent on closure downloads. Signed-off-by: Austin Seipp <aseipp@pobox.com>
Overall, building in the test profile should significantly speed up the overall build pipeline because so many less cycles are spent (on GHA runners that are certainly at high load). The goal here is to help reduce CI flake outs due to things timing out; I suspect part of the problem may be a lot of the ~15 minute time limit being used up just compiling things. This is a partial revert of b714592, which removed this previous override of the Flake `checks`. Signed-off-by: Austin Seipp <aseipp@pobox.com>
thoughtpolice
force-pushed
the
aseipp/push-lstzunxprqtv
branch
from
971910e to
83c3ac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes an extra tidbit to track down slow tests in CI.
Checklist
If applicable:
CHANGELOG.md