SECURITY.md: insert an explicit URL #5502
Open
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
force-pushed
the
ig/security-doc
branch
3 times, most recently
from
e8baaa0 to
2c66e06
Compare
martinvonz
reviewed
Jan 28, 2025
SECURITY.md
Outdated
Comment on lines
1
to
3
| To report a security issue, please use the "Report a vulnerability" button on | ||
| this page. Our vulnerability management team will respond within 3 working days | ||
| of your report. If the issue is confirmed as a vulnerability, we will open a | ||
| Security Advisory. This project follows a 90 day disclosure timeline. | ||
| GitHub's Security tab for `jj`'s main repo, also accessible at | ||
| <https://github.com/jj-vcs/jj/security/advisories>. Our vulnerability management |
There was a problem hiding this comment.
What do you think about simplifying to "... button under Advisories."?
There was a problem hiding this comment.
How about this?
Because of my (armchair) concern about phishing, I also wanted to give people enough breadcrumbs to be able to find the right place without using the link, in case they feel (rightly or wrongly) worried about using the link.
There was a problem hiding this comment.
I was thinking that the reader was accessed this doc via https://github.com/jj-vcs/jj/security/policy. I think you're saying that it may be useful to give the full instructions in case they find this doc in the source tree. Makes sense.
ilyagr
force-pushed
the
ig/security-doc
branch
from
2c66e06 to
3145aec
Compare
The previous "on this page" statement is wrong more often than not. Unfortunately there is no "Report a vulnerability" button on https://github.com/jj-vcs/jj/security/policy, and looking for such a button from https://github.com/jj-vcs/jj?tab=security-ov-file leads to confusion. This is not the end of the world, but I don't see much security downside to clarifying it (that is, I don't think *not* having a link protects against phishing in any real way).
ilyagr
force-pushed
the
ig/security-doc
branch
from
3145aec to
4ad8a33
Compare
thoughtpolice
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous "on this page" statement is wrong more often than not. Unfortunately there is no "Report a vulnerability" button on https://github.com/jj-vcs/jj/security/policy, and looking for such a button from https://github.com/jj-vcs/jj?tab=security-ov-file leads to confusion.
This is not the end of the world, but I don't see much security downside to clarifying it (that is, I don't think not having a link protects against phishing in any real way).