Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NaNs and process hanging #45

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Remove NaNs and process hanging #45

merged 7 commits into from
Dec 14, 2023

Conversation

jj1bdx
Copy link
Owner

@jj1bdx jj1bdx commented Dec 14, 2023

This pull request includes the fixes for the following bugs:

  • Causing a hung process during the startup period before valid audio signals are coming out
  • Causing displaying -nan in the output level meter in broadcast FM and NBFM
    • The NaN is presumably generated by volk_32fc_s32f_atan2_32f() in PhaseDiscriminator::process()
    • This bug also causes output disruption when the multipath filter is activated for broadcast FM

This pull request includes the following enhancements:

  • Streamlining processing flow in the main for loop of main()
  • Removing the initial waiting period for startup; the output is now activated from the block number 1
  • Adding Utility::remove_nans(), a function to check and substitute NaNs and infinity values in IQSamplesDecodedVector

@jj1bdx jj1bdx self-assigned this Dec 14, 2023
@jj1bdx jj1bdx merged commit 38e73f0 into dev Dec 14, 2023
@jj1bdx jj1bdx deleted the dev-nan-check branch December 15, 2023 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant