New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gsub instead of gsub! #284

Merged

jjasghar merged 1 commit into rabbitmq:master from gocardless:steve-fix-cluster-provider

Jul 17, 2015

Contributor

stevedomin commented Jul 14, 2015

Currently some of the methods in the cluster provider are broken because they are using gsub! instead of gsub, as well as splitting on an array.

This PR fixes it by:

Using gsub instead of gsub!
Removing duplicate split


          Use gsub instead of gsub!

e6b29fe

alexpop mentioned this pull request

cluster resource : possible bug in running_nodes method #285

Closed

Contributor

alexpop commented Jul 14, 2015

Fixes #282 and #285

atongen mentioned this pull request

Fixes issue calling string methods on nil object in cluster provider #288

Closed

jjasghar merged commit e6b29fe into rabbitmq:master

stevedomin deleted the steve-fix-cluster-provider branch

July 20, 2015 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet