Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue calling string methods on nil object in cluster provider #288

Closed
wants to merge 2 commits into from
Closed

Fixes issue calling string methods on nil object in cluster provider #288

wants to merge 2 commits into from

Conversation

atongen
Copy link

@atongen atongen commented Jul 14, 2015

  • Do not use gsub! (edit in place) when we want to capture the return value in the result variable.
  • Removes redundant call to split method

@atongen
Copy link
Author

atongen commented Jul 16, 2015

Just noticed that this is basically a dup of pull request #284. Either would address the issue.

@jjasghar
Copy link
Contributor

Thanks, i'm going to take the other one.

@jjasghar jjasghar closed this Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atongen @jjasghar