Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column mismatch broken sort #55

Merged
merged 4 commits into from
Apr 12, 2020
Merged

Fix column mismatch broken sort #55

merged 4 commits into from
Apr 12, 2020

Conversation

bookwyrm
Copy link
Contributor

Fixes #54

@bookwyrm
Adds helper function to check if an orderby clause is sortable
aa7aaac 
The way that WP and this library handle specifying orderby fields is not working well. The orderby clause from WordPress is the actual meta_key that posts should be sorted by, but PostType expects the orderby clause to be the column_key. This works fine until the meta_key and the column_key are different.

This commit makes the check more extensive and supports the actual sort behavior as implemented by WordPress.
@bookwyrm
Reflow code to match existing style
74485ce
@bookwyrm
Get the meta_key for sorting from the actual sort options
968893e
@bookwyrm
Updates for linter
e3d8720
unapersona
unapersona approved these changes Feb 26, 2020
View reviewed changes
Copy link

@unapersona unapersona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as a patch and works perfectly, thanks!

@jjgrainger
Copy link
Owner

Thank you for this. Approved and merged :)

@jjgrainger jjgrainger merged commit 627a236 into jjgrainger:master Apr 12, 2020
@jjgrainger jjgrainger mentioned this pull request Apr 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unapersona unapersona unapersona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting broken when column key and orderby column do not match
3 participants
@bookwyrm @jjgrainger @unapersona