Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in files.py, corrected typings for Item.get_files function. #680

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Fixed typo in files.py, corrected typings for Item.get_files function. #680

merged 1 commit into from
Feb 18, 2025

Conversation

karpour
Copy link
Contributor

@karpour karpour commented Feb 15, 2025

Based on the code, both glob_pattern and exclude_pattern in Item.get_files should both be of type str | list[str] | None rather than str | None

@jjjake jjjake merged commit 28b44db into jjjake:master Feb 18, 2025
11 checks passed
@jjjake
Copy link
Owner

jjjake commented Feb 18, 2025

Thanks, karpour!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karpour @jjjake