HuggingFaceModel #21
Open
HuggingFaceModel #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjleng
reviewed
Apr 11, 2024
| logger.info(f"SHA256 hash of the file: {sha256_value}") | ||
| return upload_id, sha256_value | ||
|
|
||
| def upload_fs_to_s3( |
There was a problem hiding this comment.
This has a lot of duplicates with upload_to_s3. need consolidation
There was a problem hiding this comment.
The upload_to_s3 method is currently unused for huggingface model, as it's specifically designed for transferring data from an HTTP stream generated by requests to an S3 bucket.
jjleng
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example schema:
HuggingFaceModel {
repo_id: "TheBloke/CapybaraHermes-2.5-Mistral-7B-GPTQ",
files: ["*.json", "model.safetensors"],
inference_devices: ["cpu"], // gpu, tpu, etc
quantization: "GPTQ", // GPTQ, AWQ, GGUF_Q4_0, etc
runtime: "llama.cpp", // vLLM, pytorch, etc
prompt_template: "chatml", // chatml, llama-2, gemma, etc.
}
I have established a list object named SUPPORTED_MODELS_V2 within the supported_model.py file.
If the model name exists in the SUPPORTED_MODELS_V2 list object, the system will employ the new HuggingFaceModel for downloading. Otherwise, it will resort to the old logic.