Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hard set solc version at 0.8.19 bc of rollup limitations #509

Merged
merged 3 commits into from
Aug 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ If you are not running Supabase, then the search functionality will not work. Yo

### Updating bytecode

Whenever you make a change to smart contracts, increment the version by `x.1`. Then generate the bytecode and version it as described below.
Whenever you make a change to smart contracts or really whenever the bytecode files change (could be that [the compiler version got changed and so no bytecode changed, but remappings were reformatted](https://github.com/jk-labs-inc/jokerace/pull/509)), increment the version by `x.1`. Then generate the bytecode and version it as described below.

The purpose of this is so that we have a way to tell exactly what bytecode a contract that we read from a chain has and exactly how it was deployed given its version number.

In order to generate and/or update the bytecode of your project, run

Expand Down
1 change: 1 addition & 0 deletions packages/forge/foundry.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
src = "src"
out = "out"
libs = ["lib"]
solc-version = "0.8.19" # most rollups don't support past this - https://twitter.com/pashovkrum/status/1690298101448208384?s=46

# See more config options https://github.com/foundry-rs/foundry/tree/master/config
2 changes: 1 addition & 1 deletion packages/forge/src/governance/Governor.sol
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ abstract contract Governor is Context, ERC165, EIP712, GovernorMerkleVotes, IGov
* @dev See {IGovernor-version}.
*/
function version() public view virtual override returns (string memory) {
return "3.2";
return "3.3";
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/forge/src/modules/RewardsModule.sol
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ contract RewardsModule is Context {
* @dev Version of the rewards module. Default: "1"
*/
function version() public view virtual returns (string memory) {
return "3.2";
return "3.3";
}

/**
Expand Down
4 changes: 3 additions & 1 deletion packages/react-app-revamp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ If you are not running Supabase, then the search functionality will not work. Yo

### Updating bytecode

Whenever you make a change to smart contracts, increment the version by `x.1`. Then generate the bytecode and version it as described below.
Whenever you make a change to smart contracts or really whenever the bytecode files change (could be that [the compiler version got changed and so no bytecode changed, but remappings were reformatted](https://github.com/jk-labs-inc/jokerace/pull/509)), increment the version by `x.1`. Then generate the bytecode and version it as described below.

The purpose of this is so that we have a way to tell exactly what bytecode a contract that we read from a chain has and exactly how it was deployed given its version number.

In order to generate and/or update the bytecode of your project, run

Expand Down
Loading