Fix kotlin Multiplatform Test: The test requires Java 17 but in our github action we only have 11 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By downgrading the android-gradle plugin, it also runs with java 11
also fix the resolution of relative output directories: for the Multiplatform-test it failed because it resolved the path to ":android/my/path"
balrok
force-pushed
the
bugfix/fix-kotlin-multiplatform-test
branch
from
06cc42a
to
8b85eb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By downgrading the android-gradle plugin, it also runs with java 11
also fixed how the absolute path is computed for a relative output directory. This was failing in the test.
And replaced the deprecated projectDir/buildDir variables: https://docs.gradle.org/current/userguide/upgrading_version_8.html#deprecated_project_builddir_can_cause_script_compilation_failure