fix missing override for InventoryReportRenderer #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balrok
force-pushed
the
bugfix/fix-overrides-for-inventoryreportrenderer
branch
3 times, most recently
from
dad1be4
to
8a01186
Compare
After introducing the delayed loading of the overrides file with PR jk1#286, the overrides for the first dependency in the InventoryReportRenderer were not applied. It is not entirely clear to me, why this happens. I just assume it has to do with groovy-magic related to automatically calling the getters of properties. To resolve this, the base-property was renamed, so it doesn't conflict with the getter.
balrok
force-pushed
the
bugfix/fix-overrides-for-inventoryreportrenderer
branch
2 times, most recently
from
bd729cd
to
0da07a0
Compare
- upload unit test results always
balrok
force-pushed
the
bugfix/fix-overrides-for-inventoryreportrenderer
branch
from
0da07a0
to
0608d94
Compare
|
Thank you for the contribution. The snapshot testing is indeed a concept the plugin can benefit from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After introducing the delayed loading of the overrides file with PR #286, the overrides for the first dependency in the InventoryReportRenderer were not applied.
It is not entirely clear to me, why this happens. I just assume it has to do with groovy-magic related to automatically calling the getters of properties.
To resolve this, the base-property was renamed, so it doesn't conflict with the getter.
For writing the tests, I updated to spock 2.4 because it has the Snapshot-Testing Feature. I implemented it like this: when executing it locally, the tests will always become green but may update the snapshot-files. When running in the CI the tests will become red if the snapshot changed. I think it is an OK solution because the snapshot-files are checked into git anyways and even if the tests locally won't fail, a developer will see that things changed.
Also I updated the github actions because their version were mentioned to be deprecated.