Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquey vulnerabilities in static analysis report. #499

Closed
andrius-pra opened this issue Mar 18, 2022 · 6 comments
Closed

jquey vulnerabilities in static analysis report. #499

andrius-pra opened this issue Mar 18, 2022 · 6 comments

Comments

@andrius-pra
Copy link

Static analysis tools marks rrule@2.6.9 as vulnerable component.

image

Is there any reason why demo files are included in the npm package?

@sunshineo
Copy link
Contributor

I had a quick look but could not figure out whether the tsconfig.json or the webpack.config.js should be modified to exclude the demo from the package.
Maybe there should be an rrule-demo project to just host the demo

@davidgoli
Copy link
Collaborator

davidgoli commented Jun 5, 2022

jquery is included in package.json which is probably why it's showing up here. Rrule does not import jquery directly, but the demo does use it. Agree that there should be a separate project for the demo - would love to review a PR that did that.

@sunshineo
Copy link
Contributor

@davidgoli I'll try

sunshineo pushed a commit to sunshineo/rrule that referenced this issue Jun 6, 2022
sunshineo pushed a commit to sunshineo/rrule that referenced this issue Jun 6, 2022
@sunshineo
Copy link
Contributor

Demo page is deployed by gh-pages branch, it is diverged from master branch (for example dist folder not ignored and demo page served from there). It requires manual merge from master branch to update demo page to use the latest rrule lib.
This PR makes gh-pages branch only for the demo page and use rrule from npm. Currently 2.7.0. For future updates, instead of merge from the tip of master, we simply update the version number in package.json

@sunshineo
Copy link
Contributor

sunshineo commented Jun 6, 2022

@davidgoli if we still want a completely separated project for the demo, I can do that but it will be under my Github account with url https://sunshineo.github.io/rrule/ or https://sunshineo.github.io/rrule-demo/
This will requires url changes everywhere and also better to remove the gh-pages branch in the main repo. So I prefer to keep using the gh-pages branch.
I'm now working on remove all demo code from master branch

sunshineo pushed a commit to sunshineo/rrule that referenced this issue Jun 6, 2022
@sunshineo
Copy link
Contributor

#510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants