Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toText missing BYSETPOS #629

Open
gbulfon opened this issue Jul 11, 2024 · 3 comments
Open

toText missing BYSETPOS #629

gbulfon opened this issue Jul 11, 2024 · 3 comments

Comments

@gbulfon
Copy link

gbulfon commented Jul 11, 2024

Hello, I think I found a bug.

RRule.fromString("FREQ=MONTHLY;BYSETPOS=3;BYDAY=TH;INTERVAL=3;UNTIL=20240730T220000Z").toText();

returns : 'every 3 months on Thursday until July 30, 2024'
should be : 'every 3 months on 3rd Thursday until July 30, 2024'

Is the BYSETPOS check missing?
@Corepex
Copy link

Corepex commented Jul 17, 2024

It seems that the text version of BYSETPOS is missing in every configuration

@Corepex
Copy link

Corepex commented Jul 17, 2024

This should be the solution: #504

@gbulfon
Copy link
Author

gbulfon commented Jul 18, 2024

This should be the solution: #504

Yes I found it but it's not been incorporated. I had to patch it myself. Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbulfon @Corepex