Apply bysetpos weekly totext #504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply bysetpos to weekday totext
tests for totext bysetpos
remove extra bracket
|
@jakubroztocil Please review it ASAP to fix bug #436 |
zldavis
reviewed
Aug 2, 2023
|
Please merge this :) |
|
@jkbrzt could you please merge that one? |
Corepex
approved these changes
Jul 17, 2024
afilp
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply bysetpos to weekday totext
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
Merged in or rebased on the latest
mastercommitLinked to an existing bug or issue describing the bug or feature you're
addressing
rule.toText() to respect BYSETPOS #436
Written one or more tests showing that your change works as advertised