Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Date inputs to prevent infinite loops #282

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Conversation

davidgoli
Copy link
Collaborator

@davidgoli davidgoli commented Sep 30, 2018

Fixes #281.


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised
  • Run yarn build to rebuild the dist/ files

@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #282 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   89.26%   89.32%   +0.06%     
==========================================
  Files          21       21              
  Lines        1900     1902       +2     
  Branches      567      572       +5     
==========================================
+ Hits         1696     1699       +3     
+ Misses        204      203       -1
Impacted Files Coverage Δ
src/rrule.ts 98.23% <100%> (+0.02%) ⬆️
src/dateutil.ts 93.71% <100%> (+0.14%) ⬆️
src/parseoptions.ts 94.77% <100%> (+0.83%) ⬆️
src/masks.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d680f21...7b41068. Read the comment docs.

@davidgoli davidgoli merged commit eab930c into master Sep 30, 2018
@davidgoli davidgoli deleted the validate-inputs branch September 30, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants