allow passing WeekdayStr to byweekday like the types suggest is possible #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekilah
commented
Oct 30, 2019
| } | ||
|
|
||
| const wd = wday as Weekday |
There was a problem hiding this comment.
this cast was hiding the bug, and is now not necessary since we've handled all the other cases for the type of wday
|
@jakubroztocil for review? |
|
or maybe one of @lyschoening @davidgoli - other authors listed on the README? |
davidgoli
approved these changes
Nov 7, 2019
|
awesome, thanks @davidgoli . what's the cadence for releasing to |
|
I do, but I'm not as active on this project as I used to be - I can put together a release in the next day or so however. |
|
@davidgoli friendly ping 👀 |
|
@ekilah 2.6.3 published! apologies for the delay |
|
awesome, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the types suggest passing in weekday strings for
byweekday, e.g.:options.byweekday = 'MO'should be allowed, but it doesn't work. this fixes thatThanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing