Bugfix - Apply dtstart option when forceset: true #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which happens when using
rrulestr
in a similar way to this:In the past (talking
~2.2.0
ish) this would applydtstart
and the created rules would have the dtstart. That's no longer the behavior. Having an explicitdtstart
which could even override theDTSTART:
specified in the rule was quite convenient, and this PR brings it back.What's interesting is that this is already the behavior when one doesn't specify
forceset: true
.Thanks for contributing to
rrule
!To submit a pull request, please verify that you have done the following:
master
commitaddressing