Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid UNTIL value for years < 10 #626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix invalid UNTIL value for years < 10 #626

wants to merge 1 commit into from

Conversation

macmillen
Copy link

fixes #385

espen
espen reviewed Jul 11, 2024
View reviewed changes
test/parsestring.test.ts

it('parses a dtstart with a year lower than 10', () => {
const expectations: [string, Partial<Options>][] = [
['DTSTART:00,40101T000000Z', { dtstart: datetime(4, 1, 1) }],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an invalid date value?

espen
espen reviewed Jul 11, 2024
View reviewed changes
src/parsestring.ts
@@ -5,6 +5,7 @@ import { Days } from './rrule'

export function parseString(rfcString: string): Partial<Options> {
const options = rfcString
.replace(/DTSTART:00,/, 'DTSTART:000')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a bit hackish too me. would not this be for trying to parse invalid values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espen espen espen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid UNTIL value
2 participants
@macmillen @espen