Bugfix

[Andarist]

Problem is that in options.wkst is kept a number and not a Weekday object. Therefore if wkst is set then we get wrong RFC string with 'WKST=0' when it should be 'WKST=MO' which makes parsedString = RRule.optionsToString(options) not parseable to RRule object again with RRule.fromString(parsedString) cause at line :1415 we have such assignment - options.wkst = RRule[value]; - value === 0 in that instead of 'MO' and problem is that RRule[0] is non existent. And that makes code at line :520 accessible and it raises an Exception (TypeError: Cannot read property 'weekday' of undefined) as nor Weekday nor number nor null is stored in opts.wkst.

[jkbrzt]

Thanks!

[jkbrzt]

I've had to undo this change as it was throwing exceptions.

Could you please provide an example where wkst is a number instead of a Weekday?

[Andarist]

var rrule = RRule.fromString('FREQ=WEEKLY;DTSTART=20110201T093000Z;INTERVAL=5;UNTIL=20130130T230000Z;BYDAY=MO,FR');

RRule.optionsToString(rrule.options); // and you get in the string WKST=0, and it ain't valid iCal option, you cannot parse it back to RRule object

[jkbrzt]

Please read the documentation on rrule.options and rrule.origOptions here:

var rrule = RRule.fromString('FREQ=WEEKLY;DTSTART=20110201T093000Z;INTERVAL=5;UNTIL=20130130T230000Z;BYDAY=MO,FR');

rrule.toString()
"FREQ=WEEKLY;DTSTART=20110201T093000Z;INTERVAL=5;UNTIL=20130130T230000Z;BYDAY=MO,FR"

rrule.origOptions.byweekday
[Weekday, Weekday]

rrule.origOptions.byweekday.toString()
"MO,FR"

rrule.origOptions.byweekday[0].toString()
"MO"

[jkbrzt]

The (documented) inconsistency regarding rrule.options.byweekday is an issue and is causing the problem you mention for example when you access it directly or do something like RRule.optionsToString(rrule.options). But it should be addressed on another level than your proposed pull request.