Minor changes for MELPA readiness #1
Merged
+5
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also uses the `user-emacs-directory` location to store the file instead of hardcoding `~/.emacs.d`.
jkdufair
reviewed
Mar 4, 2021
| @@ -80,7 +69,7 @@ globally relevant." | |||
| (defvar *spotify-client-api-oauth2-ts* nil | |||
| "Unix timestamp in which the OAuth2 token was retrieved. | |||
| This is used to manually refresh the token when it's about to expire.") | |||
| (defvar *spotify-client-api-oauth2-token-directory* "~/.emacs.d/.cache/spotify" | |||
| (defvar *spotify-client-api-oauth2-token-directory* (concat (file-name-as-directory user-emacs-directory) ".local/cache/spotify") | |||
There was a problem hiding this comment.
Right, it appears that the .local path is a custom modification made internally by doom-emacs. I'll remove the change.
There was a problem hiding this comment.
I'll go ahead and merge and make that tweak. Thanks! @bnjmnt4n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a
Package-Requiresheader to allow dependencies to be fetched automatically by package managers, and removed theeval-when-compileblock around(require 'oauth2), which does not seem to be necessary anymore (please let me know if it still causes issues).I also made some other non-related changes, do let me know if you want me to separate them out:
user-emacs-directoryinstead of hardcoding~/.emacs.dmake-empty-filecreates the full path, instead of just erring if the directories were not created